@certik please let me know if this is the correct approach to move further. There are many tests that still fail and it would require fixes to complete this.

I think so. This seems what I was thinking.

To help with the tests, let's hide it behind a compiler option, that way the new name would only be used with the option is given, so current tests should pass.

To help with the tests

Let's first fix all the tests such that all of them are working and then we can add it behind a compiler option so that it does not break with the compiler flag.

Sure. Depends what the failures are --- the issue with unique names is that all the C tests (in tests/ directory) then will fail, as the name is changing with every run (as it should!).

I have added the fix, but it's kind of hack-ish as we need to keep in mind about unique_id while emitting the symbol name which can fail easily. How about writing a pass if we have --generate-object-code, then it would replace all the symbol_names with unique names. This would also help with any such backend where there would be linking issues like C, C++, etc.

I think writing the ASR pass will be better, as it will fix this issue for all the backends. Here is what the pass could do:

• all module level symbols will receive proper name mangling: prepend module name, and optional unique hash (depending on a compiler option).

I think this might be as easy as just modifying the symbol table, since we don't reference things by name, except in ExternalSymbols, so those would have to be updated too.

I'll keep this PR open as all the tests pass successfully. I'll work on writing a pass in a new PR tomorrow morning.

Completed in #2149